Feat/milestone trustful zuzalu d app interface #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add trustful-context
Feat/welcome text role
Feat/give badge
fea: add share page
Feat/my badges
feat: add my-badge details
Feat/smart contract functions
| toast.error( | ||
| `Unsupported network. Please switch to the ${isDev ? 'Scroll Sepolia' : 'Scroll'} network.`, | ||
| ); | ||
| switchChain({ chainId: isDev ? scrollSepolia.id : scroll.id }); |
There was a problem hiding this comment.
Maybe this needs to use switchChainAsync in order to make sure the user switches chain when necessary?
| from: address, | ||
| role: role, | ||
| account: validAddress.address as `0x${string}`, | ||
| msgValue: BigInt(0), |
There was a problem hiding this comment.
- I cannot see your feedbacks if you resolve the conversations
- Is this value always the same? As per my research it is always 0, being possible to set this as a function internal function
| from: address, | ||
| role: role, | ||
| account: validAddress.address as `0x${string}`, | ||
| msgValue: BigInt(0), |
There was a problem hiding this comment.
| from: address, | ||
| uid: schemaUID as `0x${string}`, | ||
| action: action, | ||
| msgValue: BigInt(0), |
There was a problem hiding this comment.
| from: address, | ||
| sessionTitle: inputValuesTextArea['removeSessionTitle'], | ||
| sessionOwner: validAddress.address as Address, | ||
| msgValue: BigInt(0), |
There was a problem hiding this comment.
Comment on lines
+48
to
+50
| { | ||
| action: ADMIN_ACTION.JOIN_SESSION, | ||
| }, |
There was a problem hiding this comment.
@heronlancellot I can not see your feedback properly if you resolve the conversation
Comment on lines
+48
to
+50
| { | ||
| action: ADMIN_ACTION.JOIN_SESSION, | ||
| }, |
There was a problem hiding this comment.
See how you are defining the arrays as [{ action: something }, { action: something_else }] when these could be defined as [something, something_else]
|
|
||
| const [isCopied, setIsCopied] = useState<boolean>(false); | ||
| const [isVisible, setIsVisible] = useState(false); | ||
| // const prefixToGiveBadge = 'https://trustful.ing/give-badge'; |
There was a problem hiding this comment.
Can you please add comments on the commented sections, sharing why these are commented and if these are open action items?
| setEventDetails(eventsData); | ||
| } | ||
| } catch (error) { | ||
| console.log('error', error); |
There was a problem hiding this comment.
Suggested change
| console.log('error', error); | |
| console.error('error', error); |
…ce' into feat/milestone-trustful-zuzalu-dApp-interface
…zalu-dApp-interface Feat/milestone trustful zuzalu d app interface
| const iconColor = | ||
| (inputAddress && isAddress(inputAddress)) || | ||
| (badgeInputAddress && isAddress(badgeInputAddress?.address)) | ||
| ? 'text-[#000000 ]' |
There was a problem hiding this comment.
Suggested change
| ? 'text-[#000000 ]' | |
| ? 'text-[#000000]' |
| } else if (inputBadge.uid === TRUSTFUL_SCHEMAS.ATTEST_EVENT.uid) { | ||
| encodeParam = TRUSTFUL_SCHEMAS.ATTEST_EVENT.data; | ||
| encodeArgs = [inputBadge.title, commentBadge ?? '']; | ||
| console.log('badgeInputAddress', badgeInputAddress); |
There was a problem hiding this comment.
Suggested change
| console.log('badgeInputAddress', badgeInputAddress); |
| ROLES.VILLAGER, | ||
| badgeInputAddress.address, | ||
| ); | ||
| console.log('isVillager', isVillager); |
There was a problem hiding this comment.
Suggested change
| console.log('isVillager', isVillager); |
| parseAbiParameters(encodeParam), | ||
| encodeArgs, | ||
| ); | ||
| console.log('data', data); |
There was a problem hiding this comment.
Suggested change
| console.log('data', data); |
| toast.error( | ||
| 'Address already checked-out: Address already have this badge.', | ||
| ); | ||
| console.log('!isVillager2', !isVillager); |
There was a problem hiding this comment.
Suggested change
| console.log('!isVillager2', !isVillager); |
| if (!inputBadge) { | ||
| setLoading(false); | ||
| toast.error('Invalid Badge: Please select a badge to give.'); | ||
| console.log('!inputBadge', !inputBadge); |
There was a problem hiding this comment.
Suggested change
| console.log('!inputBadge', !inputBadge); |
| if (!badgeInputAddress) { | ||
| setLoading(false); | ||
| toast.error('Invalid Ethereum Address: Please provide a valid address.'); | ||
| console.log('!badgeInputAddress', !badgeInputAddress); |
There was a problem hiding this comment.
Suggested change
| console.log('!badgeInputAddress', !badgeInputAddress); |
| if (!address) { | ||
| setLoading(false); | ||
| toast.error('No account connected: Please connect your wallet.'); | ||
| console.log('!address', !address); |
There was a problem hiding this comment.
Suggested change
| console.log('!address', !address); |
| data: data, | ||
| value: BigInt(0), | ||
| }; | ||
| console.log('attestationRequestData', attestationRequestData); |
There was a problem hiding this comment.
Suggested change
| console.log('attestationRequestData', attestationRequestData); |
| inputBadge.uid, | ||
| attestationRequestData, | ||
| ); | ||
| console.log('response', response); |
There was a problem hiding this comment.
Suggested change
| console.log('response', response); |
| export const TheFooterNavbar = () => { | ||
| const params = useParams(); | ||
| const { push } = useRouter(); | ||
| // const { villagerAttestationCount } = useContext(WalletContext); |
There was a problem hiding this comment.
Suggested change
| // const { villagerAttestationCount } = useContext(WalletContext); |
| } | ||
| }, []); | ||
|
|
||
| const villagerAttestationCount = Number(1); |
There was a problem hiding this comment.
I imagine this logic needs to be dynamic, right?
| </Text> | ||
| </Box> | ||
| )} | ||
| {/* <Box |
There was a problem hiding this comment.
Please add a comment on why this is commented out
| as={IconButton} | ||
| aria-label="Options" | ||
| icon={ | ||
| <Flex className="p-[6px] gap-2 items-center"> |
There was a problem hiding this comment.
Suggested change
| <Flex className="p-[6px] gap-2 items-center"> | |
| <Flex className="p-1.5 gap-2 items-center"> |
Comment on lines
+34
to
+36
| {/* {isOpenMenu && ( | ||
| <DropdownProfile isOpenMenu={isOpenMenu} onClose={closeMenu} /> | ||
| )} */} |
There was a problem hiding this comment.
A comment on why this is out, please! And in every commented out section, please :)
Suggested change
| {/* {isOpenMenu && ( | |
| <DropdownProfile isOpenMenu={isOpenMenu} onClose={closeMenu} /> | |
| )} */} | |
| {/* {isOpenMenu && ( | |
| <DropdownProfile isOpenMenu={isOpenMenu} onClose={closeMenu} /> | |
| )} */} |
context/TrustfulContext.tsx
Outdated
|
|
||
| // host_ + titleSession(Name-Session) + _ + Timestamp | ||
|
|
||
| // nas sessoes que eu sou owner adicionar badge de host e atendee |
There was a problem hiding this comment.
Suggested change
| // nas sessoes que eu sou owner adicionar badge de host e atendee | |
| // TODO: nas sessoes que eu sou owner adicionar badge de host e atendee |
context/TrustfulContext.tsx
Outdated
| userAddress: address as Address, | ||
| }); | ||
|
|
||
| console.log('eventsxxxx', events); |
There was a problem hiding this comment.
Suggested change
| console.log('eventsxxxx', events); |
context/TrustfulContext.tsx
Outdated
|
|
||
| if (spaceIds) { | ||
| for (const spaceId of spaceIds) { | ||
| console.log('spaceId', spaceId); |
There was a problem hiding this comment.
Suggested change
| console.log('spaceId', spaceId); |
context/TrustfulContext.tsx
Outdated
| eventid: event.eventId, | ||
| userAddress: address as Address, | ||
| }); | ||
| console.log('sessionssessionssessionssessions', sessions); |
There was a problem hiding this comment.
Suggested change
| console.log('sessionssessionssessionssessions', sessions); |
context/TrustfulContext.tsx
Outdated
| } | ||
| } | ||
| } catch (error) { | ||
| console.log('error', error); |
There was a problem hiding this comment.
Suggested change
| console.log('error', error); | |
| console.error('error', error); |
…://github.com/heronlancellot/ZuzaluCityOS into feat/milestone-trustful-zuzalu-dApp-interface
…zalu-dApp-interface Feat/milestone trustful zuzalu d app interface
heronlancellot
pushed a commit
to heronlancellot/ZuzaluCityOS
that referenced
this pull request
Nov 15, 2024
feat: move Invalid Date to end
…zalu-dApp-interface feat: merge-main-into-zuzalu
…://github.com/heronlancellot/ZuzaluCityOS into feat/milestone-trustful-zuzalu-dApp-interface
…zalu-dApp-interface Feat/milestone trustful zuzalu d app interface
fix: improve layout responsiveness and styling adjustments
Refactor/toast
…zalu-dApp-interface Feat/toast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.